patternfly-elements icon indicating copy to clipboard operation
patternfly-elements copied to clipboard

[fix] generator | npm run new wizard allows you to create attributes with spaces in them

Open wesruv opened this issue 5 years ago • 3 comments

I ran through npm run new and made my attributes loaded, endpoint, css and got pfe-loaded, pfe- endpoint and pfe- css at the end

wesruv avatar May 01 '20 17:05 wesruv

@wesruv Great catch! I'll see if I can't work in a fix soon.

castastrophe avatar May 05 '20 14:05 castastrophe

I think I found a related issue, thought I'd tack it on here. I have properties that have multiple words, so I used dash delimited and this was the output: image

  static get properties() {
    return {      login-link: {
        title: "Login-link",
        // Valid types are: String, Boolean, and Number
        type: Boolean
      },       logout-link: {
        title: " logout-link",
        // Valid types are: String, Boolean, and Number
        type: Boolean
      },       avatar-url: {
        title: " avatar-url",
        // Valid types are: String, Boolean, and Number
        type: Boolean
      },       full-name: {
        title: " full-name",
        // Valid types are: String, Boolean, and Number
        type: Boolean
      }};
  }

wesruv avatar Jan 22 '21 18:01 wesruv

Just to be more thorough, I know the space issue hasn't been addressed, but thought I'd capture it image

wesruv avatar Jan 22 '21 18:01 wesruv