patternfly-elements icon indicating copy to clipboard operation
patternfly-elements copied to clipboard

minify-html-literals error

Open zhawkins opened this issue 3 years ago • 1 comments

I'm running into a rollup error when trying to consume a element that imports pfe-icon. I've tracked it to this issue: https://github.com/asyncLiz/rollup-plugin-minify-html-literals/issues/14

which lead me to: https://github.com/patternfly/patternfly-elements/blob/8499a6ebac6f12c02c75be718320018d0143f5e6/elements/pfe-icon/pfe-icon.ts#L185

Removing this style attribute lead to rollup minifying html literals correctly.

zhawkins avatar Jul 22 '22 17:07 zhawkins

We have this with static html templates as well, in https://github.com/asyncLiz/minify-html-literals/issues/37

Preferably we could fix upstream, but barring that, we can solve locally by refactoring (back) to control flow logic with the static templates and by imperatively setting a css var in icon

bennypowers avatar Jul 24 '22 11:07 bennypowers