patternfly-elements icon indicating copy to clipboard operation
patternfly-elements copied to clipboard

[pfe-button][pfe-cta] contrast does not pass for secondary button on "saturated"

Open brianferry opened this issue 3 years ago • 1 comments

Description of the issue

The pfe-button component secondary button variant needs to be updated to provide greater contrast between the text and the background.

Steps to Reproduce

  1. https://patternflyelements.org/components/button/demo/
  2. Run this snippet:
    document.querySelector("pfe-band:nth-of-type(2)").colorPalette = 'accent';
    
  3. Observe color contrast error. Currently, it looks like this: image
  4. https://patternflyelements.org/components/cta/demo/
  5. Focus the Secondary + wind variant example on saturated and darkest cards
  6. Observe color contrast errors: Screen Shot 2022-04-28 at 11 36 06 Screen Shot 2022-04-28 at 11 36 11

Impacted component(s)

  • pfe-button
  • pfe-cta

brianferry avatar Apr 12 '22 20:04 brianferry

This is true for cta wind variant on accent when focused, as well https://github.com/patternfly/patternfly-elements/blob/7239cb491e85779622a486e7b8efe11d19ef5670/elements/pfe-cta/test/pfe-cta.spec.ts#L1017-L1019

bennypowers avatar Apr 28 '22 08:04 bennypowers