patternfly-elements icon indicating copy to clipboard operation
patternfly-elements copied to clipboard

[fix] ol.primary-list--primary add margin between items

Open heyMP opened this issue 4 years ago • 0 comments

Description of the issue

ol.primary-list--primary found in pfe-sass and pfe-styles relies on our .pfe-l-grid utility to layout the items in a grid based format. In addition to this, it should also provide a fallback for when the user does not implement .pfe-l-grid.

By default, the ol.primary-list--primary class does not add proper margin between siblings. We should fix that by explicitly adding standard li margin.

Impacted component(s)

  • pfe-sass
  • pfe-styles

Steps to reproduce

  1. Go to https://patternflyelements.com/elements/pfe-styles/demo/
  2. Scroll to 'Primary Ordered List'
  3. Inspect the ol element
  4. Remove the following grid classes pfe-l-grid pfe-m-gutters pfe-m-all-6-col-on-lg

Expected behavior

It should have a standard li margin between each of the li siblings

Screenshots

Screen Shot 2021-06-21 at 11 07 51 AM

heyMP avatar Jun 21 '21 15:06 heyMP