patternfly-design icon indicating copy to clipboard operation
patternfly-design copied to clipboard

Requesting new toggle button component to trigger drawer

Open simrandhaliw opened this issue 3 years ago • 7 comments

Requirement

The API Designer design team has come across a use case that requires including a count of issues in the toolbar section on the Editor page. This count of issues would trigger a side drawer that lists the issues. The count changes based on whether the user resolved the issue(s) or not.

Currently, there are no PF components that support this use case properly. While exploring some design variations, I created the following mockups for the toggle button.

Design samples

Screen Shot 2022-06-07 at 11 39 33 AM (1)

Mockup link (provides context): https://www.figma.com/proto/BswZf9XbyY1VOTHAdUOUgx/API-Designer?node-id=1952%3A15436&scaling=min-zoom&page-id=0%3A1&starting-point-node-id=1952%3A15436

simrandhaliw avatar Jun 15 '22 19:06 simrandhaliw

@mmenestr I see that you placed this on our design sync meeting for tomorrow so just assigning to you for now for follow-up.

mcarrano avatar Jun 22 '22 17:06 mcarrano

@simrandhaliw I've added this to our feature roadmap. Currently I am scheduling out into Q4, but let me know if you are needing to hit any specific release targets.

mcarrano avatar Jul 01 '22 15:07 mcarrano

The API Designer service might go GA by the end of Q3 (the date is still TBD). And it would be great if we could have this component before the GA date. Can this be pushed to an earlier roadmap target? @mcarrano

simrandhaliw avatar Jul 05 '22 15:07 simrandhaliw

@simrandhaliw I can pull this forward to our 2022.12 release which is scheduled for mid-September. Hopefully that will enable this to make the GA.

mcarrano avatar Jul 11 '22 14:07 mcarrano

Great! Thanks, @mcarrano!

simrandhaliw avatar Jul 11 '22 14:07 simrandhaliw

Here are the links to the proposed design: Sketch: https://www.sketch.com/s/de96f297-317d-451b-abcc-8b9a4b87afdc Marvel: https://marvelapp.com/prototype/idfijd4/screens

simontalusan avatar Aug 03 '22 20:08 simontalusan

Thanks @simontalusan . I have opened https://github.com/patternfly/patternfly/issues/5012 to begin implementation of this.

@simrandhaliw see the designs attached. After a few iterations, we modified your original designs to use a plain button with a badge to the right. We discussed use of the toggle button as your original design showed, but decided against that as it was primarily intended for use as part of a button group. The plain button with the badge, as shown, provides better differentiation from other toolbar actions. Although I'd like to implement this so that a badge can be added to any button variant. In this case, the button will not retain state, but we felt that was unnecessary since it will be evident to users that the drawer is opened and they can close either by clicking the button again or clicking the drawer's close button. Let me know if you have any questions.

mcarrano avatar Aug 05 '22 14:08 mcarrano