patternfly-3 icon indicating copy to clipboard operation
patternfly-3 copied to clipboard

Vertical Navigation active item can be set when not navigated to.

Open Layla-P opened this issue 8 years ago • 5 comments

Using the 2 level vertical navigation. If I click on a top level nav to open the second level but then decide not to navigate to any of the links in the secondary menu, the parent is made active even though I have not navigated to it. I have fixed the issue by removing line 1408 (setActiveItem) in patternfly.js however, I have not tested that for any knock on effects.

Layla-P avatar Aug 11 '17 08:08 Layla-P

Hi @Layla-P . Default active menu item is used for display selected status. I think it's a part of design intention.

dabeng avatar Feb 06 '18 05:02 dabeng

@Layla-P apologies for the delay. I'm looking into this... it makes sense to me that on click would navigate you however you could use hover to view the available options in the secondary. Does this address the concern?

LHinson avatar Apr 30 '18 13:04 LHinson

@jgiardino given you are looking into nav updates, will you take this feedback into consideration during those updates?

LHinson avatar Jul 03 '18 18:07 LHinson

This is definitely a JS update. JS is adding the .active class on click. I think this could be reviewed as part of #723, which probably requires some design and JS investigation into what our options are.

jgiardino avatar Jul 09 '18 18:07 jgiardino

Thanks for your input @jgiardino!

LHinson avatar Jul 09 '18 19:07 LHinson