patternfly
Would notification drawer benefit from a general empty state?
Related to #526
The individual empty tab messages are a big improvement. Its possible that a user could still be a bit frustrated opening each tab only to find that there are no notifications. It may be beneficial to provide a generalized way to indicate to the user that there are no new notifications at all.
That may be able to be solved programmatically by updating the notifications-body.html with something like:
<div ng-if="!totalNotificationCount">
<!-- show a message if there zero notifications -->
</div>
<div ng-if="totalNotificationCount">
<!-- show the current body -->
</div>
If this is acceptable, then I would simply propose an update to the docs.
Another possibility might be to provide a new attrib for an empty state template:
notification-body-include="notification-body.html"
notification-body-empty-include="notification-body-empty.html"
At first glance this seems like it would be nice as it abstracts away some of the noise, but I'm not sure if its worth the cost of $watch-ing notification-groups to count all of the notifications in each array in order to trigger the template change.
@jeff-phillips-18
In OpenShift, the accordion is not used so this issue does not apply. Changing to priority 3 for now. Will bring back up if other products experience this issue!
