angular-patternfly
angular-patternfly copied to clipboard
pfFilter Enhancements
Recently in OpenShift Origin Catalog/Console we had to customize the pfFilter directive:

Changes/Enhancements:
- Change the result label from "Active filters:" to "Active Filters:" (capital "F")
- Change the result label from "n Results" to "n of m items"
- Disable the filter input field if there is only 1 (original) item available
- We would've liked to hide the 'n items' results label when there were no active filters, but doing so caused the label to briefly appear, then disappear (flickering).
- Moved the filter results label, tags, 'Clear All' link to same line as the filter selection and input fields (inline mode).
These enhancements need to be vetted by PatternFly designers: Design Doc
This looks like good stuff. I checked on the terminology guidelines and it looks like "Items" should be capitalized in #2. Ideally, that message would be variable so it could be set to "3 of 40 Hosts" or something like that if we knew exactly what was being filtered. I think it's fine to leave the "n Items" label on the page when no filters are active. It's good information to have. @beanh66 what are your thoughts?