styleguidekit-assets-default icon indicating copy to clipboard operation
styleguidekit-assets-default copied to clipboard

Keyboard shortcuts vs accesskeys

Open ba55ie opened this issue 9 years ago • 4 comments

The keyboard shortcuts aren't working on my local installation (patternlab-node v2.3.0) and online. Tested with the latest Chrome and Firefox.

My suggestion is to use accesskeys instead of jwerty, because it will make the site more accessible and you can ditch the JS dependency.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey

ba55ie avatar Jul 29 '16 07:07 ba55ie

Ah, according to the docs this feature is disabled, but it seems to be active in the code: https://github.com/pattern-lab/styleguidekit-assets-default/blob/9935ac6155a1afe86dc894df68773e72de94c441/src/js/styleguide.js#L116

ba55ie avatar Jul 29 '16 07:07 ba55ie

@ba55ie -

Some of them are in there but not all. I'll look into accesskey as well. Thanks for the heads up.

dmolsen avatar Jul 29 '16 19:07 dmolsen

I asked around about this: https://twitter.com/brad_frost/status/917429730630098951 and got some interesting results from a11y folks. It sounds like accesskeys can interfere with screen readers' built-in keyboard shortcuts. I'm going to ponder this a bit more, but in any case, I think moving to a non-jQuery version (referenced in #78) is a good idea.

bradfrost avatar Oct 09 '17 21:10 bradfrost

OK, thanks for the heads up. Too bad that the usage of access keys still causes problems after so many years...

ba55ie avatar Oct 10 '17 07:10 ba55ie