plugin-drupal-twig-components icon indicating copy to clipboard operation
plugin-drupal-twig-components copied to clipboard

Add create_attribute()

Open webflo opened this issue 9 years ago • 5 comments

create_attribute() is a new twig function in Drupal core 8.3.x https://www.drupal.org/node/2818293

The Attribute class contains a lot of logic, i am not sure if we should copy it, trim it down or maybe add drupal/core as a composer dependency and use it directly?

webflo avatar Jan 10 '17 20:01 webflo

Hmm aleksip/plugin-data-transform has the necessary classes already.

webflo avatar Jan 10 '17 21:01 webflo

Ideally these issues will land some day:

Meanwhile Data Transform Plugin has the required classes and is already a dependency of Pattern Lab Twig Standard Edition for Drupal, so maybe it could be added as a dependency here too.

aleksip avatar Jan 11 '17 09:01 aleksip

are there any news on this one?

romanovma avatar Dec 05 '17 15:12 romanovma

There's PR #8 but that won't work, needs to be a function

waako avatar Mar 19 '18 21:03 waako

just added a create_attribute function in #10

waako avatar Mar 19 '18 22:03 waako