pattern-lab
UIKit Nav Cleanup
Long overdue front-end cleanup of the Nav component to be more maintainable, more easily updated in the future and more performant. Not 100% where I want to be with this ideally (maybe 80%+) but definitely puts us in a much better spot than before.
At a high level, this includes one new feature, but most of this is just under the hood refactoring.
New Feature (Fix?)
- Only allow one top level nav link open at a time while on larger screens / nav displays as a dropdown menu
Refactor
- Updates us from using Preact v8 to Preact v10 so we can fully take advantage of Fragments, etc
- Breaks the Nav up into smaller, more manageable sub-components
- Significantly reduces the amount of UI logic required (especially with handling the active Nav item)
- Simplifies the CSS to deduplicate and streamline everything; sets us up for eventually allowing end users to officially be able to customize the UI via CSS Custom Properties
I still need to finish up doing cross browser testing on this but early testing seems very promising.
Side Note: I mistakenly branched this off of https://github.com/pattern-lab/patternlab-node/pull/1034 so I'd recommend we merge that down first to avoid merge conflicts + reduce any potential rework!
Coverage remained the same at 76.959% when pulling a2e22eed3fe87cd8cce3039454cf7b2cc1e7f967 on feature/uikit-nav-refactor into a5a12654ec3795c0c5092d55d4c72cc2a024c16c on dev.
@sghoweri are you using this to make progress against #1103 or can it be independently merged?
Update: there's at least two small CSS fixes that'll be needed here before this is good to go in IE 11 + Firefox, FYI!
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sghoweri just checking in on this - I havent reviewed in quite a while, citing your above comment
Update: there's at least two small CSS fixes that'll be needed here before this is good to go in IE 11 + Firefox, FYI!
Do you need a review for this topic or is it not finished at the moment?
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!