patternlab-node icon indicating copy to clipboard operation
patternlab-node copied to clipboard

Plugins and Engines should have access to all Pattern Lab data

Open aleksip opened this issue 6 years ago • 8 comments

There should be at least read access, but ideally also write access, at least for pattern data.

Plugins seem to have some type of access at the moment, as they are passed the patternlab instance, but I am not sure if core is expecting that data might be changed?

Engines do not seem to have access at the moment?

aleksip avatar Jun 07 '19 16:06 aleksip

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] avatar Aug 07 '19 01:08 stale[bot]

Bump

sghoweri avatar Aug 12 '19 16:08 sghoweri

Engines do not seem to have access at the moment?

this looks correct from a cursory look of an engine

bmuenzenmeyer avatar Oct 11 '19 17:10 bmuenzenmeyer

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] avatar Dec 10 '19 17:12 stale[bot]

Issue closed after going stale. It can be re-opened if still relevant.

stale[bot] avatar Jan 09 '20 18:01 stale[bot]

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] avatar Dec 19 '20 08:12 stale[bot]

As far as I can see, the pattern lab instance itself and the pattern are passed to the plugin hooks via events. I tested altering pattern data and also the pattern lab instance via the plugin tab. This worked well.

Depending on what should be done via the plugin, I assume that the events PATTERNLAB_PATTERN_BEFORE_DATA_MERGE, PATTERNLAB_PATTERN_WRITE_BEGIN, and PATTERNLAB_PATTERN_WRITE_END are not giving the requested possibilities.

Could you tell me what the plan is or was and what you wanted to archive?

JosefBredereck avatar Jan 11 '21 12:01 JosefBredereck

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] avatar Jan 09 '22 00:01 stale[bot]