Patryk Zawadzki

Results 282 comments of Patryk Zawadzki

This would need "load previous products" to appear if starting from an offset.

Since it changes the API, I'd rather merge it in its final form to avoid changing the API twice. Would you mind sharing what you'd want the final API to...

What is the motivation? Would you like to shorten the time? 5 seconds does seem like a lot of time.

Sorry, I'm on vacation until Monday. I'd like to both shorten the default and allow custom timeouts.

What is the purpose of this change? None of the values are derived from user input, the code is hard to read due to repeating patterns and none of the...

For what it's worth I would rather ditch the `SystemInfo` part and let you pass a simple dict as `extra_info`. I don't think it's worth wrapping each and every possible...

Wouldn't it be simpler to have a thread call `report(…)` instead? For example in `saleor` project I am planning to introduce a thread pool to do just that.

In either case it would be much simpler to introduce thread pooling at the `report(…)` level (as opposed to creating a new thread for each call). For example by introducing...

Please post the library in the discussion under #2. I don't think it's a good idea to officially endorse it seeing that it was only created a few days ago...

Possibly the same issue? #317