Patrick O'Doherty

Results 27 comments of Patrick O'Doherty

hey @dannyfallon 👋🏻 this wasn't a deliberate change on our part, rather I think a result of the `ubuntu:latest` target that we use in our build environments incrementing. I think...

There's a dependency issue with the `packages.json` as is. The `karma-phantomjs-launcher`. Specifically the version string it defines for the `phantomjs` package here https://github.com/karma-runner/karma-phantomjs-launcher/blob/master/package.json#L20 does not work. I observe the following...

Turns out this is actually an issue w/ `[email protected]` which is now a bit more specific when it comes to version strings https://github.com/karma-runner/karma-phantomjs-launcher/issues/42. Specifically the `phantomjs` version numbers being nonstandard...

Forked the `karma-phantomjs-launcher` to have a working dependency string. The following output is now observed from `make test` ``` ./node_modules/handlebars/bin/handlebars -f /tmp/tmp.eRRni5mjxS_templates.js app/templates/*.handlebars if ! diff --brief /tmp/tmp.eRRni5mjxS_templates.js app/js/templates.js; then...

Ah apologies, forgot to comment last night that the 404 issues are common to the old test scripts. They're not as a result of this PR. Outside of the dependency...

There's an issue opened on Github for this which I linked above. The project hasn't been touched since April so it's possibly going to be a while. I'm on this...

@seanmcne it is possible that a recent change in the client might be at issue here but without more detailed logs is it hard to tell. Would you be able...