Patrick Mylund Nielsen

icon indicating a website link https://patrickmn.com/ icon indicating an email [email protected]

icon company CTO @clovyr icon location New York City icon location Make software out of steel, not clay

Results 43 comments of Patrick Mylund Nielsen

Fix function comments based on best practices from Effective Go

I'm ok with changing this, but the changes are inconsistent: You use colons somewhere and "Funcname does a thing" in other places. It should be the latter consistently, right? Please...

Changing RWMutexMap to sync.Map

This is sufficiently mindblowing so as to be suspicious. In the docs it states > It is optimized for use in concurrent loops with keys that are stable over time,...

Changing RWMutexMap to sync.Map

Still waiting for CONTRIBUTORS change. @vidmed ?

Changing RWMutexMap to sync.Map

Unfortunately, I think @zouyx brings up a good point. I'm not sure it's worth breaking installs... :(

Changing RWMutexMap to sync.Map

Taken into consideration backwards compatibility and the uncertain performance impact, I think it's best not to merge this for now.

Add GetPossiblyExpired()

I'm not sold on this one, but not necessarily against it. Do you have an example of how this would be useful?

Thoughts if you make a v2

Thanks. I agree with everything.

Thoughts if you make a v2

FWIW: https://github.com/patrickmn/go-cache/commit/e7a9def80f35fe1b170b7b8b68871d59dea117e1

what if onEvicted func very slow

Good idea. Will try to get this into the next release.

Update item with same expiry

I'm a little confused about this. Is the Update() method intended to keep the same expiration time as the original item? In that case, can't it just re-use the previous...