Patrick Arminio

Results 669 comments of Patrick Arminio

> So since it seems like a lot of people use the docstring for implementation details, maybe I am using the docstring in an unconventional way. In other words, the...

> @patrick91 does the refactor of `StrawberryField` version 0.53.0 solve this? I think we chatted about this on discord, but for visibility, we need to update the MyPy plugin, but...

ok, so I spent a bit more time on this, and it might be possible, but it might still be best to use a plugin for this anyway. so when...

> Thanks for getting back to me @patrick91 ! Would you recommend waiting until [python/mypy#9925](https://github.com/python/mypy/pull/9925) is merged (i.e: is Strawberry planning on taking the mypy plugin approach or the strawberry...

@peniqliotuv that would work I think 😊

@gonzalezzfelipe sorry I missed your comment! what issue are you having exactly? We did a few improvements on typing since we opened this issue. Can you post a reproduction example?...

@huonw thanks for the report! I've been doing some improvements on how errors work here: https://github.com/strawberry-graphql/strawberry/pull/2027 I'll see if I can make this error case better too 😊

Reproduction here: https://play.strawberry.rocks/?gist=6ac38ba61d3c1836e723c20857cee8b0

@ThirVondukr I think you need to mark the fields as optional as well: ```python @strawberry.input class StrawberryUnset: a: Optional[int] = strawberry.UNSET b: Optional[int] = strawberry.UNSET ``` otherwise the GraphQL validation...

I wonder if that's something we can provide, or at least allow, the GraphQL spec doesn't allow it, so it would be something we do in our codebase, but I'm...