diffrax icon indicating copy to clipboard operation
diffrax copied to clipboard

fixing bugs 323 and 324

Open JadM133 opened this issue 2 years ago • 2 comments

I fixed both bugs 323 and 324 and tested linear, rectilinear and cubic interpolations with both empty and random matrices. Tests are passing but I am getting 4 warnings (which I assume are not related to the changes since they're related to some deprecation.

JadM133 avatar Nov 02 '23 02:11 JadM133

Thank you for the comment! I agree, using jnp.full is a better way. I fixed this and followed the instructions in CONTRIBUTING.md.

JadM133 avatar Nov 05 '23 01:11 JadM133

Hmm, this is a little odd -- we seem to be seeing a flake in an unrelated test. Your changes themselves seem fine. I've not seen this issue before, so possibly this is because of a change somewhere upstream in JAX?

patrick-kidger avatar Nov 07 '23 22:11 patrick-kidger