Fixed callback if DialogFragment called from an other Fragment
Good day to you.
I have been trying to use your library in my own project. And I found out that if I start DialogFragment from an Fragment then I don't receive the interface callback there, but I receive it on Activity which has started this Fragment. So I decided to add small changes to your library.
Please, check it, if everything is allright I will be very happy to help you :)
Thanks for the patch. I think that's a good idea. Do you think you could also add some tests for around the new behavior?
@yurezcv Hey, are you still interested in getting this in?
@passy Hi, sorry. I have a lot of stuff to do. But I'm interested. Could you tell me what changes I should apply to get this pull request accepted? Thank you in advance.
@yurezcv No worries, I'm in the same boat. :)
Just the two things mentioned above, ie. the class cast and removing the unnecessary changes to the XML files.
ping
I'm here :) I didn't get what you mean in "removing unnecessary changes to the XML files. There are only necessary changes. And I have already removed the class cast, but didn't push it yet.
@yurezcv Cool, the rest is okay the way it is. So it's only left to the class cast. :)
hey,
why got this pull-request never merged???
are you planning to do so?
would urgently need the "DialogFragment called from an other Fragment"-functionality (getTargetFragment())
:)
thanks.
@b3nson I don't have time to pick this up at the moment. Do you want to address the comments? Would be happy to review it.
@passy check pull request here: https://github.com/passy/Android-DirectoryChooser/pull/72 Only changes to the library-project, removed ClassCastException, no XML-changes. Is that what you meant?