Android-DirectoryChooser icon indicating copy to clipboard operation
Android-DirectoryChooser copied to clipboard

Fixed callback if DialogFragment called from an other Fragment

Open yurezcv opened this issue 11 years ago • 10 comments

Good day to you.

I have been trying to use your library in my own project. And I found out that if I start DialogFragment from an Fragment then I don't receive the interface callback there, but I receive it on Activity which has started this Fragment. So I decided to add small changes to your library.

Please, check it, if everything is allright I will be very happy to help you :)

yurezcv avatar Sep 23 '14 13:09 yurezcv

Thanks for the patch. I think that's a good idea. Do you think you could also add some tests for around the new behavior?

passy avatar Sep 26 '14 14:09 passy

@yurezcv Hey, are you still interested in getting this in?

passy avatar Nov 05 '14 08:11 passy

@passy Hi, sorry. I have a lot of stuff to do. But I'm interested. Could you tell me what changes I should apply to get this pull request accepted? Thank you in advance.

yurezcv avatar Nov 05 '14 08:11 yurezcv

@yurezcv No worries, I'm in the same boat. :)

Just the two things mentioned above, ie. the class cast and removing the unnecessary changes to the XML files.

passy avatar Nov 05 '14 09:11 passy

ping

passy avatar Jan 15 '15 11:01 passy

I'm here :) I didn't get what you mean in "removing unnecessary changes to the XML files. There are only necessary changes. And I have already removed the class cast, but didn't push it yet.

yurezcv avatar Jan 19 '15 12:01 yurezcv

@yurezcv Cool, the rest is okay the way it is. So it's only left to the class cast. :)

passy avatar Jan 19 '15 14:01 passy

hey, why got this pull-request never merged??? are you planning to do so? would urgently need the "DialogFragment called from an other Fragment"-functionality (getTargetFragment())
:) thanks.

b3nson avatar Nov 19 '15 15:11 b3nson

@b3nson I don't have time to pick this up at the moment. Do you want to address the comments? Would be happy to review it.

passy avatar Nov 19 '15 16:11 passy

@passy check pull request here: https://github.com/passy/Android-DirectoryChooser/pull/72 Only changes to the library-project, removed ClassCastException, no XML-changes. Is that what you meant?

b3nson avatar Nov 20 '15 10:11 b3nson