passwall-server icon indicating copy to clipboard operation
passwall-server copied to clipboard
verified publisher icon passwall

Go Lint Errors

Open furkanbegen opened this issue 5 years ago • 5 comments

PaswallServer should pass all linter errors defined in golangci-lint package.

furkanbegen avatar Oct 31 '20 21:10 furkanbegen

Thank you @furkanbegen. I assigned you and me about this. Thank you for your support.

yakuter avatar Oct 31 '20 21:10 yakuter

Super linter which is provided by Github could be quite efficient. Since it provides variety of lint options for a lot of environments and languages such as Dockerfile, ENV, CSS, GO, PHP and more. Just a recommendation.

mrtrkmn avatar Nov 09 '20 09:11 mrtrkmn

Maybe after fixing this linter errors, linter can add into github workflow. For decreasing linter errors in coming with new pull requests.

yusufpapurcu avatar Mar 30 '21 18:03 yusufpapurcu

Maybe after fixing this linter errors, linter can add into github workflow. For decreasing linter errors in coming with new pull requests.

This make sense

furkanbegen avatar Mar 30 '21 18:03 furkanbegen

Thank you all for your comments. I used golangci-lint but want to give a chance to super linter. I will work on linter errors and then when they all finish I will add to github actions.

yakuter avatar Mar 31 '21 06:03 yakuter