parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

fix: Saving object with a pointer field set to `undefined` throws error for Postgres

Open andrewalc opened this issue 1 year ago • 6 comments

Pull Request

Issue

Closes: #9146

Approach

Work in progress, attempting to write a failing test case. Need to see if it fails for Postgres in CI (afaik i can only test on mongo locally. It passes for mongo but shouldn't for postgres)

Tasks

  • [ ] Add tests
  • [ ] Add changes to documentation (guides, repository pages, code comments)
  • [ ] Add security check
  • [ ] Add new Parse Error codes to Parse JS SDK

andrewalc avatar Jun 06 '24 20:06 andrewalc

I will reformat the title to use the proper commit message syntax.

Thanks for opening this pull request!

Test passes for Postgres and MongoDB. Is this issue related to your custom code?

mtrezza avatar Jun 07 '24 09:06 mtrezza

Test passes for Postgres and MongoDB. Is this issue related to your custom code?

I just found out how to test with postgres locally so I'm gonna try setting that up properly first. My issue might be because I didn't configure postgres for parse correctly.

andrewalc avatar Jun 07 '24 14:06 andrewalc

@andrewalc sure, let us know how it goes, and whether the related issue can be closed.

mtrezza avatar Jun 11 '24 13:06 mtrezza

@andrewalc sure, let us know how it goes, and whether the related issue can be closed.

posted an update in the issue here, might try again if i find some time but it seems like the case i have refuses to fail in this repo

andrewalc avatar Jun 11 '24 15:06 andrewalc