parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

feat: Provide parent data when resolving with cloud function

Open bschulz87 opened this issue 2 years ago • 5 comments

Pull Request

Issue

Closes: 7621

bschulz87 avatar Oct 27 '23 16:10 bschulz87

Thanks for opening this pull request!

Could you add a test for this new feature?

mtrezza avatar Oct 28 '23 15:10 mtrezza

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c4a4a2a) 94.10% compared to head (0a54b95) 94.09%. Report is 1 commits behind head on release-5.x.x.

:exclamation: Current head 0a54b95 differs from pull request most recent head c23fcb4. Consider uploading reports for the commit c23fcb4 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           release-5.x.x    #8795      +/-   ##
=================================================
- Coverage          94.10%   94.09%   -0.01%     
=================================================
  Files                184      184              
  Lines              13814    13813       -1     
=================================================
- Hits               12999    12997       -2     
- Misses               815      816       +1     
Files Coverage Δ
src/GraphQL/loaders/schemaDirectives.js 96.00% <ø> (ø)
src/Routers/FunctionsRouter.js 94.02% <100.00%> (-0.09%) :arrow_down:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 28 '23 15:10 codecov[bot]

Well, i would add a test which confirms the presence of parent data but i don't know how to get started. The test script (npm run test= won't start on my machine: Starting a MongoDB deployment to test against...Error: Could not figure out current Linux distro (Arch, arch)

Edit: I managed to build the parse-server docker image and started a mongodb in a container but the test won't start in my environment. When omitting the pretest script it starts but the suite has timeout errors.

bschulz87 avatar Oct 29 '23 10:10 bschulz87

We have a blog article that is especially directed towards first time contributors and a more technical Contribution Guide to help you get started with setting up a test environment.

mtrezza avatar Oct 29 '23 21:10 mtrezza