parse-server icon indicating copy to clipboard operation
parse-server copied to clipboard

feat: Update ldap

Open dblythy opened this issue 2 years ago • 6 comments

Pull Request

Issue

Closes: #8592

Approach

Tasks

  • [x] Add tests
  • [ ] Add changes to documentation (guides, repository pages, code comments)
  • [ ] Add security check
  • [ ] Add new Parse Error codes to Parse JS SDK

dblythy avatar Jun 07 '23 15:06 dblythy

I will reformat the title to use the proper commit message syntax.

Thanks for opening this pull request!

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (e2e51d9) 94.43% compared to head (6af5371) 94.42%.

:exclamation: Current head 6af5371 differs from pull request most recent head f2965e7. Consider uploading reports for the commit f2965e7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8623      +/-   ##
==========================================
- Coverage   94.43%   94.42%   -0.01%     
==========================================
  Files         184      184              
  Lines       14613    14613              
==========================================
- Hits        13800    13799       -1     
- Misses        813      814       +1     
Impacted Files Coverage Δ
src/Adapters/Auth/ldap.js 94.23% <100.00%> (ø)

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 08 '23 01:06 codecov[bot]

It seems that this update isn't compatible with Node 14

dblythy avatar Jun 09 '23 04:06 dblythy

Thanks, well merge the PR in ~6~ 4 month then, when we prepare the Parse Server 7 release that drops Node 14 support.

mtrezza avatar Jun 09 '23 12:06 mtrezza

Hey, @dblythy , we plan to release this update in version 7, but there is currently a conflict with this PR. Can you please take a look to resolve that?

suathh avatar Dec 28 '23 08:12 suathh

Closing via https://github.com/parse-community/parse-server/pull/8947

mtrezza avatar Feb 26 '24 20:02 mtrezza