parse-dashboard icon indicating copy to clipboard operation
parse-dashboard copied to clipboard

Actions resulting in opening a new browser window fail when the dashboard is not mounted on "/" (see generatePath)

Open FransGH opened this issue 2 years ago • 2 comments

New Issue Checklist

Issue Description

Doing a Cmd-CLick on a pointer should open the target object in a new browser window. This works fine if the dashboard is mounted on / When there is a subpath like /parse or /dashboard the external links fail.

An earlier PR where an external link was 'hacked' by using the current location instead of generatePath worked fine when the dashboard was mounted on / and /parse Changing to generatePath appeared to work fine but was not tested on /parse.

Looking at generatePath it becomes clear that none of the links that use this function will work when the dashboard is not mounted on /

export default function generatePath(currentApp, path) {
  return `/apps/${currentApp.slug}/${path}`;
}

Steps to reproduce

  • mount the dashboard on /parse
  • cmd-click in a class on pointer
  • a new window opens with a page not found or other error (depending on server)

Actual Outcome

the new window doesn't show the dashboard but an error

Expected Outcome

The same functionality when the dashboard was mounted on /

Environment

Dashboard

  • Parse Dashboard version: 5.2.0 Alpha 1
  • Browser (Safari, Chrome, Firefox, Edge, etc.): n/a
  • Browser version: n/a

Server

  • Parse Server version: n/a
  • Operating system: n/a
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): `linux with docker and nginx' (n/a)

Database

  • System (MongoDB or Postgres): n/a
  • Database version: n/a
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): n/a

Logs

n/a

FransGH avatar May 30 '23 21:05 FransGH

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza sorry, missed this during testing after changing to generatePath. I'll look into this and fix it with a new PR.

FransGH avatar May 30 '23 21:05 FransGH