File uploading status not changing after uploading completed
New Issue Checklist
- [x ] I am not disclosing a vulnerability.
- [x ] I am not just asking a question.
- [x ] I have searched through existing issues.
- [x ] I can reproduce the issue with the latest versions of Parse Server and Parse Dashboard.
Issue Description
https://i.ibb.co/JHcYx8D/Screenshot-at-Sept-18-02-15-34.png
- File uploading status not changing after uploading completed,
When user updates a file in a field it indefinitely shows "uploading..." status but we can see the uploaded file in s3, it should change to "completed" or filename after finishing uploading operation
- Change label from "uploading..." to filename or "upload pending" or "upload waiting confirmation" or something more convenient before pressing add button
Currently when users select a file from device it's showing "uploading..." label in the selected view but actually, files are not getting uploaded at that point, file uploading only starts when the user press add button, this is a confusing implementation users waits for this 'uploading...' label to change to something like 'completed', it's a bad UX
Steps to reproduce
-
Update a file in dashboard
-
Select a file to upload in dashboard
Actual Outcome
"Uploading..." status inside view keeps displaying even after the upload is completed Showing "Uploading..." before pressing add button
Expected Outcome
-
"Uploading..." status should change to "complete" or filename when uploading operation finishes
-
Show "Uploading..." only after pressing add button, before that provide appropriate label
Environment
Dashboard
- Parse Dashboard version:
4.1.4 - Browser (Safari, Chrome, Firefox, Edge, etc.):
Chrome - Browser version:
105.0.5195.125 (Official Build) (x86_64)
Server
- Parse Server version:
5.2.5 - Operating system:
Ubuntu 22.04.1 LTS - Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc):
remote-AWS
Database
- System (MongoDB or Postgres):
MongoDB - Database version:
5.0.12 - Node version
v18.1.0 - FileAdapter - s3 (aws)
- Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc):
AWS
Logs
No logs or error messages on the browser
Thanks for opening this issue!
- 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.
i found the exact issue but not sure if the solution I have is correct or not
if (this.props.value !== prevProps.value) {
this.renderCellContent();
this.props.value._previousSave
?.then(res => this.renderCellContent())
?.catch(err => console.log(err))
}
we need to add this to parse-dashboard\src\components\BrowserCell\BrowserCell.react.js inside componentDidUpdate
@mtrezza can u help!
You could just open a PR and others (including yourself) can test if that works with the automatic dev deployment in the PR.
🎉 This change has been released in version 5.2.0-alpha.7
🎉 This change has been released in version 5.2.0-beta.2
🎉 This change has been released in version 5.2.0