node-apn icon indicating copy to clipboard operation
node-apn copied to clipboard

I miss the localised subtitle properties `subtitle-loc-key` and `subtitle-loc-args` because you're using old Apple documentation

Open funnel20 opened this issue 2 years ago • 1 comments

Thanks for this great lib.

The detailed apn.Notification documentation refers to the Apple payload documentation at https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CreatingtheNotificationPayload.html

This link is outdated, the modern docu can be found at https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification In particular Table 2 is important, as it shows a set of new keys which is not present in your Convenience Setters. Among them the subtitle and it's localised variants; subtitle-loc-key and subtitle-loc-args.

Would it be possible to add these and other missing ones and update your documentation?

funnel20 avatar Jan 22 '24 16:01 funnel20

Thanks for opening this issue!

🎉 This change has been released in version 6.2.0

parseplatformorg avatar Sep 25 '24 11:09 parseplatformorg

@mtrezza Thank you very much

funnel20 avatar Sep 26 '24 14:09 funnel20

(Forwarding your thanks to @cbaker6 who provided the PR)

mtrezza avatar Sep 26 '24 22:09 mtrezza

Version 6.2.0 successful in production after using the 2 new fields ✅ Here is the server log:

Sending 11 notifications...
 · Completed sending 11 notifications in 0.66 seconds (17 messages/second)
 · 11 sent, 0 failed

funnel20 avatar Sep 27 '24 08:09 funnel20