react-native-appupdate icon indicating copy to clipboard operation
react-native-appupdate copied to clipboard

reassignment of const variable jobId

Open nyilmaz opened this issue 7 years ago • 2 comments

https://github.com/parryworld/react-native-appupdate/blob/master/index.js#L11 here job is defined as constant but, it is reassigned here:

https://github.com/parryworld/react-native-appupdate/blob/master/index.js#L81

changing const to let resolves issue. Related error in android as follows: com.facebook.react.common.JavascriptException: undefined is not a function (evaluating 'babelHelpers.readOnlyError("jobId")') crashes application.

nyilmaz avatar Nov 14 '18 14:11 nyilmaz

Same problem in my app changing to let fix it

carvalhonm avatar Jan 14 '19 15:01 carvalhonm

I'm trying to update this module since I want to use it - I'm giving it a go here https://www.npmjs.com/package/rn-update-apk / https://github.com/mikehardy/react-native-update-apk - it's fixed and released there with an example app to make sure I didn't break anything

mikehardy avatar Mar 12 '19 04:03 mikehardy