substrate icon indicating copy to clipboard operation
substrate copied to clipboard

removed `without_storage_info` from `pallet-collective`

Open muraca opened this issue 2 years ago • 8 comments

Closes paritytech/polkadot-sdk#167

  • Proposals was removed
  • ProposalOf is now a CountedStorageMap to handle the MaxProposals bound
  • ProposalOf now stores an encoded Proposal in a BoundedVec that contains at most 4 megabytes
  • Voting is now bounded
  • Members is now bounded

Cumulus companion: cumulus#2884 here

Polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp

muraca avatar Jul 16 '23 15:07 muraca

@ggwpez could you please run benchmarks?

muraca avatar Jul 16 '23 15:07 muraca

bot bench $ pallet dev pallet_collective

juangirini avatar Jul 17 '23 07:07 juangirini

@juangirini https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3198277 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_collective. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-a09aeb1d-329f-4044-8110-364b21872a93 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] avatar Jul 17 '23 07:07 command-bot[bot]

@juangirini Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_collective has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3198277 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3198277/artifacts/download.

command-bot[bot] avatar Jul 17 '23 07:07 command-bot[bot]

The CI pipeline was cancelled due to failure one of the required jobs. Job name: cargo-check-benches Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3203848

paritytech-cicd-pr avatar Jul 17 '23 15:07 paritytech-cicd-pr

/tip small

juangirini avatar Jul 18 '23 08:07 juangirini

@juangirini A small (20 DOT) tip was successfully submitted for @muraca (12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/referenda tip

substrate-tip-bot[bot] avatar Jul 18 '23 08:07 substrate-tip-bot[bot]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 18 '23 15:08 stale[bot]