substrate icon indicating copy to clipboard operation
substrate copied to clipboard

Upgrade `wasmtime` to at least `2.0.1`

Open ozgunozerk opened this issue 3 years ago • 5 comments

Is there an existing issue?

  • [X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • [X] This is not a support question.

Description of bug

There is a known bug in wasmtime: https://github.com/bytecodealliance/wasmtime/issues/5133

that is fixed with release 2.0.1. https://github.com/bytecodealliance/wasmtime/pull/5134

The bug comes into existence under some weird circumstances that I'm unsure about the fully deterministic reasons, but it happens.

Upgrading wasmtime to 2.0.1 will get rid of this inconvenience.

Steps to reproduce

Not quite the steps to reproduce, but here is an example: https://github.com/subspace/subspace-cli/actions/runs/3734314112/jobs/6336216387#step:6:1215

ozgunozerk avatar Dec 21 '22 08:12 ozgunozerk

We only use wasmtime 1.0.0 and this issue is only for wasmtime 2.0.0?

I mean we can upgrade at some point, but you should not be affected by this?

bkchr avatar Dec 21 '22 09:12 bkchr

Nope, this issue is present for 1.0.0 and 1.0.1 and 1.0.2, all of these do not include Win32_Foundation in the feature set of windows-sys and try to import all the stuff from Foundation nevertheless.

ozgunozerk avatar Dec 21 '22 09:12 ozgunozerk

Okay :)

bkchr avatar Dec 21 '22 09:12 bkchr

Now 2.0.2 per https://rustsec.org/advisories/RUSTSEC-2022-0076.html, if clearing all advisories is desired.

kayabaNerve avatar Jan 13 '23 22:01 kayabaNerve

upgrade PR: https://github.com/paritytech/substrate/pull/13126

koushiro avatar Jan 15 '23 11:01 koushiro

Was done

bkchr avatar Feb 13 '23 18:02 bkchr