registrar: Avoid freebies in `provide_judgement`

Open gavofyork opened this issue 3 years ago • 3 comments

In provide_judgement, evaluate the return value of repatriate_reserved and do not store the judgement if it fails. The registrar will still have to pay the fees without getting any compensation but at least the user won't get a confirmed identity for free.

Oct 10 '22 08:10 gavofyork

I want to pick this up. @gavofyork @bkchr Meanwhile, should any specific error be thrown if the result coming from repatriate_reserved is an error?

Oct 10 '22 20:10 dharjeezy

You probably want to introduce a new error variant, but nothing fancy.

Oct 10 '22 20:10 bkchr

You probably want to introduce a new error variant, but nothing fancy.

Alright. done

Oct 10 '22 20:10 dharjeezy