substrate icon indicating copy to clipboard operation
substrate copied to clipboard

Deprecate `decl_*` macros

Open KiChjang opened this issue 3 years ago • 1 comments

We've now basically migrated from the previous function-like decl_* macros into the #[pallet] attribute macros, and it's time that we start deprecating/removing the old decl_ macros.

KiChjang avatar Sep 13 '22 10:09 KiChjang

@KiChjang I would like to take it up.

yourarj avatar Sep 17 '22 16:09 yourarj

There are two merge requests leading up to this https://github.com/paritytech/substrate/pull/12401 and https://github.com/paritytech/substrate/pull/12445 which are both stale&closed.
Maybe someone can give this another nudge? The old macros still pollute the code base.

ggwpez avatar Mar 15 '23 11:03 ggwpez

The deprecated Module type alias for Pallet should also be removed

juangirini avatar May 05 '23 11:05 juangirini

The deprecated Module type alias for Pallet should also be removed

I am not familiar with this, but looks like it already is deprecated?! Since two years actually…
https://github.com/paritytech/substrate/blob/9ffd3d70bfc44ab306323e33bf7d234743268b03/frame/support/procedural/src/pallet/expand/pallet_struct.rs#L197

ggwpez avatar Jun 15 '23 20:06 ggwpez

I am not familiar with this, but looks like it already is deprecated?! Since two years actually…

Yes, it's already time to remove it :)

juangirini avatar Jun 16 '23 06:06 juangirini

Okay so closing his and creating another one for removal.

ggwpez avatar Jun 16 '23 10:06 ggwpez