substrate icon indicating copy to clipboard operation
substrate copied to clipboard
verified publisher icon paritytech

https://github.com/paritytech/substrate/pull/10688 doesn't take reserved nodes into account

Open tomaka opened this issue 3 years ago • 3 comments

https://github.com/paritytech/substrate/pull/10688 enforces the maximum number of peers, even if they were reserved.

tomaka avatar Feb 05 '22 12:02 tomaka

What is the desired behavior? Not to count reserved peer connections as occupying slots?

dmitry-markin avatar Jul 21 '22 14:07 dmitry-markin

Indeed

tomaka avatar Jul 21 '22 14:07 tomaka

Partially resolved (for reserved nodes, added on startup) in https://github.com/paritytech/substrate/pull/11909

We should also account for reserved nodes, added at runtime via RPC. To implement this, we should refactor Peerset first into a sync struct https://github.com/paritytech/substrate/issues/11922. See the discussion in https://github.com/paritytech/substrate/pull/11909

dmitry-markin avatar Jul 29 '22 12:07 dmitry-markin