unused functions

Open Qualenritter opened this issue 6 years ago • 1 comments

I wrote a script (in my fork "warnke_skript/list_all_functions.sh") to identify existing and unused functions - especially for the jbson-wrapper where every function is annotated with G_GNUC_UNUSED because that file is statically included in different locations.

The following is a list of unused functions - not even the tests or benchmarks or destructors or structs call/contain these functions. Some of those functions are just empty prototypes. Some functions should be called, but the calling code is completely commented out. Some existing and used functions do not match the naming scheme j_* - for example everything in the backend-, test- and benchmark-implementations.

[ ] j_background_operation_get_num_threads
[x] j_batch_wait
[x] j_credentials_ref
[ ] j_item_get_collection
[ ] j_item_get_id
[x] j_item_get_optimal_access_size
[ ] j_item_get_status_exec
[x] j_item_ref
[ ] j_item_set_modification_time
[ ] j_item_set_size
[ ] j_item_write_exec
[x] j_kv_iterator_new_for_index
[ ] j_kv_uri_get_index
[ ] j_kv_uri_get_name
[ ] j_kv_uri_get_namespace
[ ] j_object_iterator_free
[ ] j_object_iterator_get
[ ] j_object_iterator_new
[ ] j_object_iterator_next
[ ] j_object_uri_get_index
[ ] j_object_uri_get_name
[ ] j_object_uri_get_namespace

Sep 10 '19 05:09 Qualenritter

Thanks! Most of these probably should have tests.

Sep 13 '19 08:09 michaelkuhn