parca-agent Add missing metrics

[ ] BatchWriteClient (latency, retries)

Aug 03 '22 15:08 kakkoyun

Hello, is this issue friendly to newcomer? If it is, maybe I can help on this.

Sep 24 '22 08:09 heylongdacoder

Hello, is this issue friendly to newcomer? If it is, maybe I can help on this.

Yes, definitely. Please go ahead.

Oct 05 '22 10:10 kakkoyun

@kakkoyun regarding the latency, currently from the metrics page, I saw there is a grpc_client_handling_seconds histogram. Is this already represent the BatchWriteClient latency?

Metrics example:

grpc_client_handling_seconds_bucket{grpc_method="WriteRaw",grpc_service="parca.profilestore.v1alpha1.ProfileStoreService",grpc_type="unary",le="0.005"} 1

Oct 05 '22 16:10 heylongdacoder

@kakkoyun regarding the latency, currently from the metrics page, I saw there is a grpc_client_handling_seconds histogram. Is this already represent the BatchWriteClient latency?

Metrics example:
grpc_client_handling_seconds_bucket{grpc_method="WriteRaw",grpc_service="parca.profilestore.v1alpha1.ProfileStoreService",grpc_type="unary",le="0.005"} 1

@heylongdacoder Yes, I get your point. The gRPC client metrics middleware should capture the network latency of the API. The proposed metrics should cover the overall latency with the retries, I think.

Oct 10 '22 16:10 kakkoyun

got it!

Oct 11 '22 03:10 heylongdacoder