Modbus.Net icon indicating copy to clipboard operation
Modbus.Net copied to clipboard

Replacement of hard-coded string in MachineReader.cs

Open MrVitaly opened this issue 2 years ago • 2 comments

Replacement of hard-coded string "Production" to utilizing the constant Environments.Production provided by the ASP.NET Core framework. The change enhances the code quality by leveraging framework-provided constants, thereby making the solutions using the example code more maintainable, robust, and aligned with best practices.

MrVitaly avatar Oct 30 '23 20:10 MrVitaly

Got it. I will not merge this pull request because there are more places uses this code. I will take this suggestion in next push.

parallelbgls avatar Dec 01 '23 07:12 parallelbgls

Sorry, I don't think your code is correct. Please double check your code. Snipaste_2023-12-02_07-44-36

parallelbgls avatar Dec 01 '23 23:12 parallelbgls