PaperWM icon indicating copy to clipboard operation
PaperWM copied to clipboard

Support `Attach Modal Dialogs` Gnome setting

Open jtaala opened this issue 1 year ago • 3 comments

Related to #902.

Due to some (previously observed) complexities with PaperWM's tiling/window-manage model, Gnome's "Attach Modal Dialogs" mode for windows is not currently compatible with PaperWM.

As such, this Gnome setting is a managed setting in PaperWM: https://github.com/paperwm/PaperWM?tab=readme-ov-file#recommended-gnome-shell-settings

This request is to add specific support for this Gnome windowing option.

jtaala avatar Jul 21 '24 03:07 jtaala

Some notes from previously observed behaviour with "Attach Modal Dialogs":

  • comment out this line to stop PaperWM managing (and disabling) this Gnome setting: https://github.com/paperwm/PaperWM/blob/a3bbdc1e223eb539e76f8e8838ef673cf0d79d73/patches.js#L528
  • we should be able to identify a modal dialog (metaWindow) with something like
metaWindow.get_window_type() === Meta.WindowType.MODAL_DIALOG
  • I think we'd need specific logic to manage the placement (and moving with parent) within our tiling model.

jtaala avatar Jul 21 '24 03:07 jtaala

I briefly tried out the Attach Modal Dialogs setting and the main issue I encountered is that when a window moves out of the screen the dialog will move to the next monitor. I don't know if there are other issues, but that might be manageable by paperwm (e.g. hide or clip the dialog if the parent is outside of the monitor).

Lythenas avatar Jul 21 '24 11:07 Lythenas

Thanks @Lythenas. I also noticed that notice a model "dialog" moves the parent window instead, with the modal dialog staying in it's original position, until I release a button (then it snaps to the parent window) - which looks very strange.

jtaala avatar Jul 22 '24 22:07 jtaala