remote_syslog2 icon indicating copy to clipboard operation
remote_syslog2 copied to clipboard
verified publisher icon papertrail

Validation warnings

Open featalion opened this issue 10 years ago • 4 comments

Print configuration file validation warnings if:

  • no files to watch supplied
  • port is not defined, when host is

Exit with error code if no files to watch specified at all (in config and via command line).

Related to #43

featalion avatar Jun 18 '15 18:06 featalion

@leonsodhi: Code looks good to me. Can you edit the error messages (and if you think they can be clearer, comments), either by merging and creating a new branch+PR or by branching from this branch?

troy avatar Jun 19 '15 17:06 troy

@leonsodhi @troy I added more validation warnings. They will come before daemonization on parent stage or if no daemonization required. To determine the stage, I updated VividCortex/godaemon dependency. This update is workaround for #23 .

featalion avatar Jun 19 '15 21:06 featalion

@leonsodhi this looks good to me other than wording and grammar on the error strings and error code variable name ("Exists"). If it saves you time to put revisions in here for Yury to implement, go for it.

troy avatar Jun 23 '15 21:06 troy

Summing all comments above, do you want to have -D option for validations warnings? Defaults to false.

featalion avatar Jul 04 '15 23:07 featalion