papercss-react icon indicating copy to clipboard operation
papercss-react copied to clipboard

Global styles injected on import

Open hasparus opened this issue 7 years ago • 6 comments

When you import a component you also get all the global styles (like text being Neucha, sans-serif). That forces you to override styles like it's 2005. Current solution imports css. Could we use CSSModules or styled-components instead?

hasparus avatar Jul 13 '18 09:07 hasparus

I can prepare a PR if core maintainers agree.

hasparus avatar Jul 13 '18 09:07 hasparus

That sounds like a good idea to me. Please feel free to make a PR, as well. Not sure when I would have the free time to get to that. Thank you

Sent from my iPhone

On Jul 13, 2018, at 5:48 AM, hasparus [email protected] wrote:

I can prepare a PR if core maintainers agree.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Banjerr avatar Jul 13 '18 11:07 Banjerr

Okay, so I'm adding this issue to my todo list. :)

hasparus avatar Jul 14 '18 14:07 hasparus

Okay, i finally got into it. I have really important question, @Banjerr. What do you think about TypeScript? ^.^

hasparus avatar Aug 29 '18 14:08 hasparus

@hasparus i haven't used TypeScript a lot, but i'm certainly open to it if you think it would benefit the project 🙌

Banjerr avatar Aug 29 '18 15:08 Banjerr

Since the issue breaks backwards compatibility, because styles are no longer global, I'm going to use this occasion to expand examples a little bit. screen shot 2018-09-02 at 14 26 20-fullpage

hasparus avatar Sep 02 '18 12:09 hasparus