gnet icon indicating copy to clipboard operation
gnet copied to clipboard

feat: add multiple listener support

Open leki75 opened this issue 3 years ago • 3 comments

1. Are you opening this pull request for bug-fixes, optimizations or new feature?

New feature

2. Please describe how these code changes achieve your intention.

This PR will add multi-listener support. The user can specify multiple IP:port pairs separated by commas.

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

The gnet.Run command will accept multiple IP:port pairs like this:

gnet.Run(echo, "tcp://192.168.0.100:8000,192.168.0.100:8001,192.168.0.100:8002")

4. Checklist

  • [x] I have squashed all insignificant commits.
  • [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • [ ] I have written unit tests and verified that all tests passes (if needed).
  • [ ] I have documented feature info on the README (only when this PR is adding a new feature).
  • [x] (optional) I am willing to help maintain this change if there are issues with it later.

leki75 avatar Oct 17 '22 21:10 leki75

Wondering if this supports binding multiple protocols at one, for ex. Mixing udp and tcp. Also, is there any news on this?

misterquestions avatar Feb 05 '23 06:02 misterquestions

Is there a planned time to accept this PR?

gnolizuh avatar Jan 12 '24 07:01 gnolizuh

Is there a planned time to accept this PR?

This PR is still in WIP status, I'd love to review it once @leki75 finishes it.

panjf2000 avatar Jan 13 '24 02:01 panjf2000

Move to #578

panjf2000 avatar Apr 20 '24 15:04 panjf2000