fcm-rust icon indicating copy to clipboard operation
fcm-rust copied to clipboard

FCM API has been deprecated for removal June 2024

Open chris13524 opened this issue 2 years ago • 13 comments

The API endpoint being used has been deprecated and will be removed in June 2024.

chris13524 avatar Sep 27 '23 19:09 chris13524

hey, I've recently worked on implementing fcm calls on my rust app, and was able to achieve connecting to the new auth api using the gauth crate. I can open a pr which implements that.

@panicbit @pimeys

adnanjpg avatar Nov 01 '23 21:11 adnanjpg

@panicbit this needs to be addressed, but I think you've got too much on your plate. This library hasn't been updated in a year. I'd be happy to take over maintenance, can we discuss that? We need this library at my company. You can reach me here and privately at dan [at] upduo.com

eloff avatar Dec 08 '23 22:12 eloff

@adnanjpg Could you perhaps already create that PR, or share some code which implements this?

rj76 avatar Dec 21 '23 15:12 rj76

@rj76 sure, I'll share an example code here by the weekend, opening a pr will take a while though as im a bit busy these few weeks

adnanjpg avatar Dec 21 '23 15:12 adnanjpg

@adnanjpg thank you so much :) maybe I can put together a PR if time allows

rj76 avatar Dec 21 '23 16:12 rj76

@rj76 here you go. please follow the instructions written in the .env file and fill in a device id that you want the notification sent to in main.rs

adnanjpg avatar Dec 23 '23 08:12 adnanjpg

@eloff I think it's best for you to open an issue about taking over the maintenance, if there's still no response then you can invite contributors to your fork

adnanjpg avatar Dec 29 '23 17:12 adnanjpg

@eloff thanks to @adnanjpg the client change that uses gauth-rs is already finished, but still needs some love and testing. I'll post the link to the fork here when done.

rj76 avatar Dec 29 '23 18:12 rj76

@rj76 hi, i had been working on this for the past hour and i was about to finish too, seems like we should've coordinated better

anyway, assuming you've made more progress on this than i have, im going to pause my work and wait for you

if you need any help, please don't hesitate to mention me

adnanjpg avatar Dec 29 '23 19:12 adnanjpg

@adnanjpg Would you like to review and possibly test?

https://github.com/rj76/fcm-rust

rj76 avatar Dec 30 '23 14:12 rj76

@rj76 hi, the work you've done looks fantastic, there's just some tiny mistakes & refactors, and also there's some errors. I will be opening a pr on your repo with the fixes I've put & open issues with the concerns I have

adnanjpg avatar Dec 30 '23 16:12 adnanjpg

if everything was good i made i would be worried :grin: thanks in advance for your time and feedback

rj76 avatar Dec 31 '23 11:12 rj76

@rj76 hi, in case you have not noticed I had submitted a pr yesterday on your repo. happy new year

adnanjpg avatar Dec 31 '23 19:12 adnanjpg