flask icon indicating copy to clipboard operation
flask copied to clipboard

Pyright types fixes

Open brendon-codes opened this issue 1 year ago • 2 comments

Fixes various Pyright types errors.

fixes #5549

brendon-codes avatar Aug 07 '24 02:08 brendon-codes

@davidism Ok I made a new combined issue and a new combined PR. Checks are passing. I left a note in this PR with a question. I will pause on any new code in this PR until I get initial review feedback.

brendon-codes avatar Aug 07 '24 04:08 brendon-codes

Hi @davidism Anything I should change on this PR?

brendon-codes avatar Aug 09 '24 15:08 brendon-codes

It looks like you don't have "Maintainers are allowed to edit this pull request." enabled, which means I can't push some additional fixes. I'll close this and open a new PR, unless you see this before I get there.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

davidism avatar Oct 24 '24 00:10 davidism

continued in #5620

davidism avatar Oct 24 '24 21:10 davidism