io-app icon indicating copy to clipboard operation
io-app copied to clipboard

fix: [IOBP-638] Add nested scroll enabled flag on the current payment webview modal

Open Hantex9 opened this issue 1 year ago • 2 comments

Short description

This PR is aimed at solving a problem that persists only on some Android devices in which when entering the required OTP in the final payment step within the webview, upon tapping on the input field to enter the OTP code the keyboard would either not appear or when it did appear it was no longer clickable.

List of changes proposed in this pull request

  • Added the nestedscrollEnabled prop to the webview;

How to test

To test this fix, start the as-is payment stream on a device or emulator that is an Android 10 or 11 in UAT environment and verify that when tapping on the form present in the OTP code entry, the keyboard works correctly

Hantex9 avatar May 09 '24 13:05 Hantex9

Affected stories

  • 🐞 IOBP-638: Problema tap tastiera sulla webview di pagamento lato Android

Generated by :no_entry_sign: dangerJS against 39d8ca6c1d9678d3c790466eac0578a4d9702aea

pagopa-github-bot avatar May 09 '24 13:05 pagopa-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.52%. Comparing base (4f204b4) to head (39d8ca6). Report is 76 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5758      +/-   ##
==========================================
+ Coverage   48.42%   49.52%   +1.09%     
==========================================
  Files        1488     1603     +115     
  Lines       31617    31886     +269     
  Branches     7669     7697      +28     
==========================================
+ Hits        15311    15792     +481     
+ Misses      16238    16040     -198     
+ Partials       68       54      -14     
Files Coverage Δ
ts/components/wallet/PayWebViewModal.tsx 63.63% <ø> (-2.28%) :arrow_down:

... and 420 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2349078...39d8ca6. Read the comment docs.

codecov[bot] avatar May 10 '24 14:05 codecov[bot]