io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore: [IOPID-1509], [IOPID-1484] Integrate new DS on email insert/validation in onboarding flow and integrate new MP events

Open Ladirico opened this issue 2 years ago • 4 comments

Short description

Integrate new DS on email insert/validation flow, codebase cleaning and integration of MP events

List of changes proposed in this pull request

  • Integrate new DS on email insert/validation flow
  • Fix FAQ visualization
  • Change flow
  • Add ProgressLoader component in validation email screen
  • Change logic of polling in validation email screen (Add Saga)
  • Change copy
  • Add mixpanel events
  • Refactor code
    • Transform validation email modal into screen
    • Delete unused screens
    • Change some routes name

Test

[!TIP] Run e2e tests

✅ NEW FLOW - EMAIL NOT TAKEN ✅ ✅ NEW FLOW - EMAIL ALREADY TAKEN ✅ ✅ NEW FLOW - WITHOUT EMAIL ✅

Accessibility Test

🍏 A11Y iOS 🍏 🤖 A11Y Android 🤖

How to test

Run the application and test:

  1. firstOnboarding flow using io-dev-api-server: is_email_validated": false, and"is_email_already_taken": true (+ close the application during the validation)
  2. firstOnboarding flow using io-dev-api-server: is_email_validated": false, and"is_email_already_taken": false (+ close the application during the validation)
  3. Test too the email change in profile flow to check that changes on screens have not led to regressions

Ladirico avatar Mar 12 '24 13:03 Ladirico

Affected stories

  • ⚙️ IOPID-1484: [APP] Implementazione evento mixpanel per tracciamento tap su "invia nuova mail" subtask of
    • 🌟 IOPID-1479: [APP] Disabilitare pulsante "invia e-mail"

Generated by :no_entry_sign: dangerJS against d8a0e787788b814723936020c5d34f5225b1ab96

pagopa-github-bot avatar Mar 12 '24 13:03 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 25.53957% with 207 lines in your changes are missing coverage. Please review.

Project coverage is 47.95%. Comparing base (18e480e) to head (d8a0e78). Report is 8 commits behind head on master.

:exclamation: Current head d8a0e78 differs from pull request most recent head dce3508. Consider uploading reports for the commit dce3508 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5586      +/-   ##
==========================================
- Coverage   48.15%   47.95%   -0.20%     
==========================================
  Files        1443     1439       -4     
  Lines       31121    30966     -155     
  Branches     7598     7545      -53     
==========================================
- Hits        14985    14849     -136     
+ Misses      16065    16049      -16     
+ Partials       71       68       -3     
Files Coverage Δ
ts/components/RemindEmailValidationOverlay.tsx 7.75% <ø> (ø)
ts/config.ts 100.00% <ø> (ø)
ts/features/fastLogin/store/selectors/index.ts 88.88% <ø> (-0.77%) :arrow_down:
...eatures/fci/screens/valid/FciDataSharingScreen.tsx 70.45% <ø> (ø)
...tures/zendesk/screens/ZendeskSupportHelpCenter.tsx 72.30% <100.00%> (+2.30%) :arrow_up:
ts/navigation/routes.ts 100.00% <ø> (ø)
ts/sagas/startup/checkAcknowledgedEmailSaga.ts 90.00% <100.00%> (+11.42%) :arrow_up:
ts/screens/profile/ProfileDataScreen.tsx 70.58% <ø> (+2.40%) :arrow_up:
ts/store/actions/profile.ts 100.00% <100.00%> (ø)
...res/zendesk/components/ZendeskSupportComponent.tsx 76.47% <80.00%> (-4.49%) :arrow_down:
... and 13 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18e480e...dce3508. Read the comment docs.

codecov[bot] avatar Mar 12 '24 13:03 codecov[bot]

@mariateresaventura please check the copy! 😁

Ladirico avatar Mar 15 '24 13:03 Ladirico

@mariateresaventura please check the copy! 😁

done!

mariateresaventura avatar Mar 18 '24 16:03 mariateresaventura

We close it due to a wrong rebase in favor of https://github.com/pagopa/io-app/pull/5632

shadowsheep1 avatar Mar 26 '24 15:03 shadowsheep1