io-app icon indicating copy to clipboard operation
io-app copied to clipboard

chore: CieRequestAuthenticationOverlay as navigation modal

Open CrisTofani opened this issue 2 years ago • 2 comments

Short description

Include a summary of the changes.

List of changes proposed in this pull request

  • Feature A
  • Feature B

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

CrisTofani avatar Mar 06 '24 18:03 CrisTofani

Warnings
:warning: Please include a Jira ticket at the beginning of the PR title

Example of PR titles that include Jira tickets:

  • single story: [PROJID-123] my PR title
  • multiple stories: [PROJID-1,PROJID-2,PROJID-3] my PR title

Generated by :no_entry_sign: dangerJS against f1a07d5c3b18c85bd939147f8a5ffcc20d3692ea

pagopa-github-bot avatar Mar 06 '24 18:03 pagopa-github-bot

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 47.93%. Comparing base (9f72690) to head (81c42cd). Report is 14 commits behind head on master.

:exclamation: Current head 81c42cd differs from pull request most recent head f1a07d5. Consider uploading reports for the commit f1a07d5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5577      +/-   ##
==========================================
- Coverage   48.31%   47.93%   -0.39%     
==========================================
  Files        1466     1424      -42     
  Lines       31114    30860     -254     
  Branches     7559     7484      -75     
==========================================
- Hits        15034    14793     -241     
+ Misses      16011    16008       -3     
+ Partials       69       59      -10     
Files Coverage Δ
ts/components/LoadingSpinnerOverlay.tsx 100.00% <ø> (ø)
ts/navigation/AuthenticationNavigator.tsx 66.66% <ø> (+26.66%) :arrow_up:
ts/navigation/routes.ts 100.00% <ø> (ø)
...components/cie/CieRequestAuthenticationOverlay.tsx 12.90% <28.57%> (-0.29%) :arrow_down:
ts/screens/authentication/cie/CiePinScreen.tsx 11.53% <0.00%> (-0.23%) :arrow_down:

... and 368 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d69265d...f1a07d5. Read the comment docs.

codecov[bot] avatar Mar 07 '24 11:03 codecov[bot]