chore: [IOBP-527] Remove require cycles in CGN

[forrest57]

Short description

removed require cycles in CGN folder

List of changes proposed in this pull request

• moved circular imports to shared files

How to test

yarn jest and yarn tsc:noemit should be enough; The existance of circular dependencies has been checked this VSCode extension, along with VSCode's very useful search in non-edit views feature.

[pagopa-github-bot]

Affected stories

• ⚙️ IOBP-527: risolvere require cycle in CGN subtask of
  • ⚙️ IOBP-516: Risolvere warnings Require cycle nei flussi bonus e wallet

Generated by :no_entry_sign: dangerJS against 08d2d268af4f4c3a9d4f0509baaecef55af3dc85

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.92%. Comparing base (9f72690) to head (38182e8). Report is 207 commits behind head on master.

:exclamation: Current head 38182e8 differs from pull request most recent head 08d2d26

Please upload reports for the commit 08d2d26 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5480      +/-   ##
==========================================
- Coverage   48.31%   47.92%   -0.40%     
==========================================
  Files        1466     1399      -67     
  Lines       31114    30188     -926     
  Branches     7559     7390     -169     
==========================================
- Hits        15034    14468     -566     
+ Misses      16011    15651     -360     
  Partials       69       69              

Files	Coverage Δ
ts/features/bonus/cgn/navigation/actions.ts	50.00% <ø> (ø)
...ga/networking/activation/getBonusActivationSaga.ts	11.62% <ø> (ø)
.../cgn/saga/networking/eyca/details/getEycaStatus.ts	94.11% <ø> (ø)
...a/orchestration/activation/handleActivationSaga.ts	72.22% <ø> (ø)
.../cgn/screens/merchants/CgnMerchantDetailScreen.tsx	12.82% <ø> (ø)
...gn/screens/merchants/CgnMerchantLandingWebview.tsx	14.28% <ø> (ø)
...n/screens/merchants/CgnMerchantsListByCategory.tsx	6.66% <ø> (ø)
...s/cgn/screens/merchants/CgnMerchantsListScreen.tsx	10.25% <ø> (ø)
ts/features/bonus/cgn/store/actions/activation.ts	100.00% <ø> (ø)
...eatures/bonus/cgn/store/actions/eyca/activation.ts	100.00% <ø> (ø)
... and 6 more

... and 588 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27c6779...08d2d26. Read the comment docs.

[mastro993]

Running npx madge --circular --extensions ts ./ command I still get require cycle warnings in CGN flows:

ts/App.tsx > ts/RootContainer.tsx > ts/navigation/AppStackNavigator.tsx > ts/features/bonus/cgn/navigation/navigator.tsx > ts/features/bonus/cgn/screens/CgnDetailScreen.tsx > ts/features/bonus/cgn/components/detail/CgnUnsubscribe.tsx > ts/store/actions/navigation.ts > ts/features/wallet/creditCard/screen/CreditCardDetailScreen.tsx > ts/features/wallet/component/features/PaymentMethodFeatures.tsx > ts/features/wallet/component/features/PaymentMethodInitiatives.tsx > ts/navigation/params/AppParamsList.ts > ts/features/messages/navigation/params.ts > ts/features/pn/navigation/params.ts > ts/features/pn/screens/PaidPaymentScreen.tsx > ts/screens/wallet/payment/TransactionSummaryScreen.tsx > ts/navigation/params/WalletParamsList.ts > ts/features/bonus/common/navigation/navigator.tsx > ts/features/bonus/common/screens/AvailableBonusScreen.tsx > ts/screens/services/ServiceDetailsScreen.tsx > ts/components/services/SpecialServices/SpecialServicesCTA.tsx > ts/features/pn/components/ServiceCTA.tsx

[github-actions[bot]]

This pull request is stale because it has been open for 60 days with no activity. If the pull request is still valid, please update it within 14 days to keep it open or merge it, otherwise it will be closed automatically.