pact-python icon indicating copy to clipboard operation
pact-python copied to clipboard

Problem installing pact standalone ruby app from github - Proxy Blocks URL

Open guilhermecgs opened this issue 6 years ago • 6 comments

Hi Folks,

I am having problem downloading ruby standalone app from github URL.

The company I work for blocks github url by default using a proxy.

Can I make a PR to a setup.py that only python itself is installed (and do not try to install ruby app)?

(My plan is to install ruby app manually OR use a docker image...)

guilhermecgs avatar Dec 26 '19 12:12 guilhermecgs

We have a similar facility in the JS implementation (see https://github.com/pact-foundation/pact-node/blob/master/README.md#pact-download-location).

Pact Go assumes it's on the path and checks it's installed correctly. You may need to include a check for the correct installed versions if you do this, because now the implementation can get out of sync with the dependencies.

mefellows avatar Dec 26 '19 23:12 mefellows

@mefellows : So, the work outline would be: (correct me if I am wrong)

  1. Create a option to install only the python library and do not install the ruby app (in setup.py)
  2. Create some sort of configuration to set the ruby app binaries location, just like "pact_binary_location" in JS implementation
  3. When setting this configuration, check if the correct version is installed

guilhermecgs avatar Dec 27 '19 21:12 guilhermecgs

I'm not familiar with idiomatic Python ways of doing these sorts of things, but yes something like the above sounds good.

Would love @matthewbalvanz-wf to chip in as he's the core maintainer here.

mefellows avatar Jan 05 '20 21:01 mefellows

Hi All, is there a workaround for this? I'm running in an environment where I can only access github through a reverse proxy :(

taj-p avatar Aug 17 '21 00:08 taj-p

I'm not sure of a workaround, but the ideal state I think is that Python bundles the Ruby application into the package, so at install time no network is required.

This is the plan for the FFI interface.

PR's welcome!

mefellows avatar Aug 17 '21 02:08 mefellows

Thanks for the quick response Matt and a path forward!

On Tue, 17 Aug 2021, 11:30 am Matt Fellows, @.***> wrote:

I'm not sure of a workaround, but the ideal state I think is that Python bundles the Ruby application into the package, so at install time no network is required.

This is the plan for the FFI interface.

PR's welcome!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pact-foundation/pact-python/issues/116#issuecomment-899935251, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFN7U4PRBVR7N52E2H2CM3T5G7FFANCNFSM4J7LCW4Q .

taj-p avatar Aug 17 '21 07:08 taj-p

Thanks for the great contribution @taj-p closing this now as complete

YOU54F avatar May 03 '23 17:05 YOU54F