ruby-saddler

ruby-saddler copied to clipboard

should exit 1 if rubocop error raised

1

I'm using Rubocop with Saddler like [this](https://github.com/packsaddle/example-circle_ci-pull_request_review) in Rails project on CircleCI hooked by Github push. When there are Rubocop error with my code, CircleCI build ends with no errors...

rnitta

Example for Brakeman

4

Split from #31 I don't find a checkstyle formatter for brakeman, https://github.com/presidentbeef/brakeman/blob/master/OPTIONS.md#output-options So we can use Saddler::Reporter::Github's PullRequestComment. ``` brakeman -f text \ | saddler report \ --reporter Saddler::Reporter::Github::PullRequestComment ```...

sanemat

vs. reviewdog

1

https://github.com/haya14busa/reviewdog I think reviewdog is awesome. They has single binary, no more dependency hell and simple usage. Wow! They uses original format and checkstyle! So, we can migrate to reviewdog...

sanemat

I think this is https://github.com/packsaddle/ruby-saddler-reporter-support-git 's bug on v2.0.1 with Jenkins Pull Request Builder Plugin.

sanemat

Avoid building multi times

2

If set multiple envs, e.g. ``` rvm: - 1.9.3 - 2.0.0 - 2.1 ``` This run saddler 3times :cry:

sanemat

Add example run locally

1

- add example run locally

sanemat

Example for Rails Best Practices

1

Split from #31 `rails_best_practices` has format option, so we can set a checkstyle formatter. I find a checkstyle formatter for rails_best_practices. https://github.com/maroekun/rails_best_practices-formatter I'm not sure this works fine with saddler....

sanemat

``` bash $ saddler generate rubocop #=> generate bin/build-rubocop.sh $ saddler generate eslint #=> generate bin/build-eslint.sh ```

sanemat

Add images

1

sanemat

guest

1

guest

sanemat