paceholder
Add qml
As I said in https://github.com/paceholder/nodeeditor/issues/429 it's hard to split every feature because I made (small) modification in lots of files so it's hard to have multiple PR that to conflict each others.
I think that it's better to convince you that every commit is fine :)
If you don't like some commits, I will remove them.
I wrote comments on almost every commit to add more context.
If you are fine with some commit, I can create another PR with these commits to reduce the size of the current PR.
I know this PR is huge :/ Don't hesitate to send me feedback or if you want I make some changes in this PR.
@bansan85 This PR is too big for anyone to really vet it properly. There are a bunch of different strategies one could use to manage a change set this large. Stacked PRs is one that comes to mind (partially because they're sort of a trendy thing at the moment)
Beyond that, I see a bunch of commits that don't seem to have anything to do with implementing QML support—various bug fixes, applying clang-format (on some lines that probably shouldn't have been touched to begin with), cmake packaging, deployment, silencing warnings, etc. All of these could actually be useful changes, but they don't belong together at all.
If you'd like to see these changes merged, I'd be happy to walk through which pieces can be pulled out into their own smaller PRs. However, it looks like you may no longer be working on nodeeditor (See https://github.com/paceholder/nodeeditor/issues/429#issuecomment-2473385239). If that is the case, that is totally fine too; just please close the PR.
You're right. Sometimes I think about this commit and know I should definitely clean it up... Vacation is coming. Please give me until September to remove everything not related to QML.
Remember, zooming with the mouse is buggy, but this commit is a good start.
@bansan85
Vacation is coming. Please give me until September to remove everything not related to QML.
All good! You can take as much time as you need/want. I only meant to check whether there was still any interest on this ticket. Let me know if you'd like any guidance on where/how to split these up. 😄
Branch has been cleaned. Feedback is welcome. You can read main.cpp from calculator_qml example to understand how to use Node Editor with qml.