nodeeditor icon indicating copy to clipboard operation
nodeeditor copied to clipboard

Crash when doing data propagation with a circuit in the network

Open chateauferret opened this issue 1 year ago • 3 comments

Qt Nodes is fine with a circuit in the network if there is no data propagation through the nodes, but if there is, it causes an infinite loop and a stack overflow which leads to a crash.

I have some code for finding such loops somewhere (from an attempt of my own years ago), I can try and adapt that. Alternatively we can start propagating the data and remember the connection that triggered it, then send the user a snotty message if we end up back where we started. That way would only find circuits in a propagating network, of course.

chateauferret avatar Sep 19 '24 18:09 chateauferret

i also am in the process of starting some work on this, maybe it requires a depth-first search (or breadth-first search approach to check before accepting any new connection

YashKarpe96 avatar Oct 10 '24 13:10 YashKarpe96

Connect to dfs using topology

qq978358810 avatar Oct 12 '24 15:10 qq978358810

Hey @qq978358810,

Could you provide a bit more detail on which internal classes or components you'd recommend starting with for the "connect to DFS using topology" approach? Any pointers or starting ground would be really helpful as we work on incorporating this.

Appreciate your input!

YashKarpe96 avatar Oct 16 '24 08:10 YashKarpe96

To be clear, when you say "circuit in the network," do you mean a "loop." For example, the output of a node feeding back into it's input?

Llcoolsouder avatar Jul 29 '25 20:07 Llcoolsouder

Yes, that's right.

chateauferret avatar Jul 31 '25 12:07 chateauferret

Duplicate of #198. Feel free to move the discussion over there/subscribe to that ticket for updates.

Llcoolsouder avatar Jul 31 '25 14:07 Llcoolsouder