Implementing Typography for Skia

Open tushar5526 opened this issue 3 years ago • 3 comments

Closes #373 Related to #371

Aug 08 '22 13:08 tushar5526

Hey @ziyaointl

I have called the preload right there in the userspace.py because it seemed the easy way instead of putting it in the base.py and calling it somewhere in the sketch class.

Also preload does not affect frame_count or any other sketch settings in any way so I called it in the userspace.py as of now.

Let me know your thoughts, and you can review this PR. It is good to go.

I will do multiple PRs this time and use issue #371 to keep track of the implementing typography status, instead of a single PR with many changes.

Aug 08 '22 14:08 tushar5526

And yes, I think putting preload in userspace.py is very reasonable :)

Aug 09 '22 04:08 ziyaointl

I have updated the PR and added a test for typography

Aug 10 '22 20:08 tushar5526

Kudos for adding the tests!

Aug 12 '22 05:08 ziyaointl