finalterm icon indicating copy to clipboard operation
finalterm copied to clipboard
verified publisher icon p-e-w

make clean deletes files that should not.

Open lwandrebeck opened this issue 11 years ago • 5 comments 

deleted:    data/finalterm.desktop.in
deleted:    data/org.gnome.finalterm.gschema.xml

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

lwandrebeck avatar Aug 23 '14 20:08 lwandrebeck

True, but somehow, the files are regenerated with a simple make, not requiring another invocation of CMake, so this is not really a problem IMO, as make clean in the end only "cleans" files that make can recreate.

p-e-w avatar Aug 24 '14 06:08 p-e-w

make; make clean; make ends with: [ 78%] Built target finalterm make[2]: Circular data/finalterm.desktop.in <- data/finalterm.desktop.in dependency dropped. [ 82%] Generating ../data/finalterm.desktop.in Error copying file (if different) from "/home/lwandrebeck/projets/finalterm/po/../data/finalterm.desktop.in" to "/home/lwandrebeck/projets/finalterm/data/finalterm.desktop.in". make[2]: *** [data/finalterm.desktop.in] Error 1 make[1]: *** [po/CMakeFiles/translations.dir/all] Error 2 make: *** [all] Error 2

cmake . after that gives: CMake Error at cmake/GSettings.cmake:31 (message): Schema validation error: Failed to open file '/home/lwandrebeck/projets/finalterm/data/org.gnome.finalterm.gschema.xml': No such file or directory

Call Stack (most recent call first): CMakeLists.txt:92 (add_schema)

lwandrebeck avatar Aug 24 '14 07:08 lwandrebeck

I cannot reproduce this on Fedora 20. make; make clean; make finishes without any problems at all on my system. This is very mysterious.

p-e-w avatar Sep 03 '14 17:09 p-e-w

I'm able to reproduce this if I don't run cmake from the build directory. If instead, I run <cmake .> in the main directory, then run <make; make clean; make> from the main directory instead of within build, the same error occurs.

gmittert avatar Sep 12 '14 18:09 gmittert

I'm not sure whether this is an actual problem given that it only occurs if one doesn't follow the build instructions, but even if it were I don't quite know how to go about it. org.gnome.finalterm.gschema.xml for example is not referenced anywhere apart from https://github.com/p-e-w/finalterm/blob/master/CMakeLists.txt#L92, so the deletion seems to be "implicit" somehow.

p-e-w avatar Sep 14 '14 07:09 p-e-w